D24932: Add button to open the folder in filelight to view more details

Pino Toscano noreply at phabricator.kde.org
Sat Dec 28 18:37:08 GMT 2019


pino added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1453
> +    // Open the current folder in filelight
> +    KRun::run(QStringLiteral("/usr/bin/filelight"), { properties->url() }, properties->window(), QStringLiteral("Filelight"), QStringLiteral("filelight"));
> +}

please do not hardcode the path to filelight... other than breaking on systems where filelight is installed in a prefix different than /usr, this breaks on Mac and Windows (and not only).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191228/2e02eeed/attachment.html>


More information about the Kde-frameworks-devel mailing list