D26123: Port QRegExp to QRegularExpression

David Faure noreply at phabricator.kde.org
Tue Dec 24 09:31:06 GMT 2019


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the extensive research!

INLINE COMMENTS

> kemailaddress.cpp:608
>  
>      bool tooManyAtsFlag = false;
>      bool inQuotedString = false;

[pre-existing: this bool is never set to true....]

> kemailaddress.cpp:643
> +    const QRegularExpression rx(QRegularExpression::anchoredPattern(addrRx)
> +                                , QRegularExpression::UseUnicodePropertiesOption);
> +    return  rx.match(aStr).hasMatch() && !tooManyAtsFlag;

A bit weird that this comma isn't at the end of the previous line instead :)

REPOSITORY
  R270 KCodecs

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26123

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191224/1aab9e98/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list