D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[David Edmundson]

davidedmundson added a comment.


  Generally +1

INLINE COMMENTS

> managedconfigmodule.cpp:43
>      ManagedConfigModule *_q;
> -    QList<KCoreConfigSkeleton*> _skeletons;
> +    QList<QPointer<KCoreConfigSkeleton>> _skeletons;
>  };

Any reason for doing this approach rather than connecting to QObject:: destroyed and cleaning the list as we go?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191216/5997522b/attachment-0001.html>