D25991: [KFilePlacesModel] Fix supported scheme check for devices

Kai Uwe Broulik noreply at phabricator.kde.org
Sat Dec 14 15:13:37 GMT 2019


broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A device doesn't usually have a URL so we need to actutally check the underlying device (e.g. StorageAccess or NetworkShare) for whether it is supported.

TEST PLAN
  - `kdialog --getopenfilename ~` now has my mounted ISOs and external storage now
  - didn't test with CD drives or network shares
  - KFilePlaces tests stil pass

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191214/d530bf4a/attachment.html>


More information about the Kde-frameworks-devel mailing list