D25887: [ColorScope] Work with plain QObjects again

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Dec 11 15:00:16 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise `colorScope` doesn't attach to things like `Plasma.Svg`.
  Also remove superfluous cast as `parentItem()` returns a `QQuickItem *`.

TEST PLAN
  - Battery on lock screen gets proper complementary color group again
  - didn't actually test the applet background stuff that this change was originally made for

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25887

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191211/36150b59/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list