D25824: Support archive installs with adoption commands

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Tue Dec 10 11:20:19 GMT 2019


leinir marked an inline comment as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in engine.cpp:744
> Shouldn't we make sure rootPath ends with /?
> at least with an ASSERT if we know it's there.

Hmm... It /should/ be done, but it's also not a bad thing to perform a touch of sanitising on this, so... yup, let's just do that, update incoming

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25824

To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191210/472651c2/attachment.html>


More information about the Kde-frameworks-devel mailing list