D25599: Fix plugin-metadata translations on windows

Albert Astals Cid noreply at phabricator.kde.org
Wed Dec 4 21:37:06 GMT 2019


aacid added a comment.


  In D25599#572013 <https://phabricator.kde.org/D25599#572013>, @sars wrote:
  
  > I would agree that a UNIX/POSIX env var is not the most logical thing to use on Windows, but how do we ensure that we are in sync with ki18n? The usage of QLocale in ki18n looks like it is just adding extra languages to a list of languages, not actually using QLocale to determine what catalog to load. At least LANGUAGE overrides any QLocale settings. Should ki18n not be moved to using QLocale and setDefault()?
  >
  > Do you BTW have a hint at what the "correct" place is to use QLocale::setDefault()?
  
  
  https://github.com/KDE/kxmlgui/blob/master/src/kswitchlanguagedialog_p.cpp#L81

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, cullmann, kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191204/2185c55f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list