D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Aug 28 11:54:24 BST 2019


broulik added inline comments.

INLINE COMMENTS

> slavebase.h:343
> +     */
> +    QMap<QString, QString> *mapConfig();
> +

Why return a pointer, and why is this method not `const`?
Or is this supposed to be writable? Then I would prefer returning a reference to communicate ownership properly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/7bed5ede/attachment.html>


More information about the Kde-frameworks-devel mailing list