D23367: make the sizing of the toolbuttons more coherent

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ToolButton.qml:49
> +
> +        Item {
> +            Layout.preferredWidth: Kirigami.Units.iconSizes.smallMedium + Kirigami.Units.largeSpacing

this further item enclosing is not necessary, is an object instantation more for no functional gain

> ToolButton.qml:55
> +                id: icon
> +                anchors.centerIn: parent
> +                height: Kirigami.Units.iconSizes.smallMedium

This was ok as it was, including fillwidth/fillheight (perhaps)
but with the line:
Layout.preferredWidth: control.icon.width > 0 ? control.icon.width : -1
same for preferredHeight

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23367

To: camiloh, #plasma, mart, ngraham
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/bb1e5378/attachment.html>