D23420: Use solid to check if a a KFileItem is located on a network mount

[Kai Uwe Broulik]

broulik added a comment.


  What about symlink resolution, though?
  Maybe this needs to check `linkDest()`, too. This might block but for our usecase in local files you have `UDS_LINK_DEST` populated on the kioslave side already.

INLINE COMMENTS

> kfileitem.cpp:766
> +            const Solid::StorageAccess *storageAccess = device.as<Solid::StorageAccess>();
> +            if (path.startsWith(storageAccess->filePath())) {
> +                m_slow = Slow;

If you have a location `/home/foo/foobar` and a slow mount `/home/foo/foo`, it will consider it slow because "starts with"

REPOSITORY
  R241 KIO

BRANCH
  solid-network-fs-check

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190826/426dd769/attachment-0001.html>