D23348: force applicationDirPath into first position when finding plugins

Harald Sitter noreply at phabricator.kde.org
Thu Aug 22 14:22:46 BST 2019


sitter created this revision.
sitter added reviewers: mpyne, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  applicationDirPath technically is already part of libraryPaths BUT it's
  position isn't specified and as it turns out is in fact last and not first.
  this has the unfortunate side effect that when trying to test a KIO
  slave from the cmake build directory it would not get loaded unless it
  isn't available in the system path.
  
  to ensure slaves are loaded preferably relative to the applicationDirPath
  we'll force-prepend the path to applicationDirPath

TEST PLAN
  running `bin/http_jobtest` of kio correctly loads the slave from the build dir
  
    QDEBUG : HTTPJobTest::testBasicGet() http_jobtest(2381)/(org.kde.kcoreaddons) ?[31m?[34mKPluginLoader::forEachPlugin?[0m: Checking for plugins in ("/home/me/src/git/kio/build/bin/kf5/kio", "/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/kio", "/home/me/src/git/kio/build/bin/kf5/kio")

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23348

AFFECTED FILES
  src/lib/plugin/kpluginloader.cpp

To: sitter, mpyne, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190822/026bba3b/attachment.html>


More information about the Kde-frameworks-devel mailing list