D23208: Use CMake find_dependency in CMake config file instead of find_package

Christophe Giboudeaux noreply at phabricator.kde.org
Sat Aug 17 07:41:13 BST 2019


cgiboudeaux added inline comments.

INLINE COMMENTS

> KF5SyntaxHighlightingConfig.cmake.in:4-5
> +include(CMakeFindDependencyMacro)
> +find_dependency(Qt5Core @Qt5Core_VERSION_MAJOR at .@Qt5Core_VERSION_MINOR@)
> +find_dependency(Qt5Gui @Qt5Core_VERSION_MAJOR at .@Qt5Core_VERSION_MINOR@)
>  

Please use REQUIRED_QT_VERSION defined in the top CMakeLists.txt instead of these Qt5Core_VERSION_*

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23208

To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190817/6bf96da6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list