D22905: [Permissions editor] Port icons to use QIcon::fromTheme()

Nathaniel Graham noreply at phabricator.kde.org
Sat Aug 3 03:30:19 BST 2019


ngraham created this revision.
ngraham added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The permissions editor was using custom low-resolution pixmaps, which did not respect
  the icon theme or color scheme and frequently just looked bad, including with a high
  DPI screen or when using a dark theme.
  
  This patch ports it to use icons from the active icon theme using `QIcon::fromTheme()`.
  
  BUG: 407662
  FIXED-IN: 5.62

TEST PLAN
  All functionality still works.
  
  Looks better, especially with Breeze icons, a dark color scheme, and a high DPI scale
  factor: F7144856: Looks good with Breeze dark.png <https://phabricator.kde.org/F7144856>

REPOSITORY
  R241 KIO

BRANCH
  port-to-qicon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22905

AFFECTED FILES
  src/widgets/images/group-grey.png
  src/widgets/images/group.png
  src/widgets/images/mask.png
  src/widgets/images/others-grey.png
  src/widgets/images/others.png
  src/widgets/images/user-grey.png
  src/widgets/images/user.png
  src/widgets/images/yes.png
  src/widgets/images/yespartial.png
  src/widgets/kacleditwidget.cpp
  src/widgets/kacleditwidget_p.h

To: ngraham, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190803/28f42501/attachment.html>


More information about the Kde-frameworks-devel mailing list