D16163: refactor taglibextractor to functions specific for metadata type

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> taglibextractor.h:44
> +}
> +
>  namespace KFileMetaData

can also be written as

  namespace TagLib::ID3v2 {
      class Tag;
  }
  namespace TagLib::MP4 {
      class Tag;
  }
  ...

a little bit shorter, but otherwise just a matter of style preference ...

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_taglib

REVISION DETAIL
  https://phabricator.kde.org/D16163

To: astippich, bruns
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181012/8c248361/attachment.html>