D16137: Add an option to KConfigDialog to fit page contents horizontally

Tim __ noreply at phabricator.kde.org
Fri Oct 12 17:18:02 BST 2018


kadabash added a comment.


  I have to admit, I don't know how to implement a version with flags correctly.
  
  Did I understand you correctly in that an overload with signature
  
    addPage(QWidget *page, const QString &itemName, const QString &pixmapName = QString(), const QString &header = QString(), bool manage = true, bool fitContentHorizontally = false)
  
  would be ok as well? This would then be called by the overload without the last option (i.e. the `addPage` that existed before this diff).
  
  For the second version
  
    addPage(QWidget *page, KCoreConfigSkeleton *config, const QString &itemName, const QString &pixmapName = QString(), const QString &header = QString(), bool fitContentHorizontally = false)
  
  I would then do the same.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D16137

To: kadabash
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181012/8601e1d9/attachment.html>


More information about the Kde-frameworks-devel mailing list