D17239: ovs-bridge and ovs-interface setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> ovsbridgesetting.cpp:25
> +#include <QDebug>
> +
> +NetworkManager::OvsBridgeSettingPrivate::OvsBridgeSettingPrivate()

Add defines for ovs-bridge properties and name in case NM is older than NM 1.10.0.

> ovsbridgesetting.cpp:27
> +NetworkManager::OvsBridgeSettingPrivate::OvsBridgeSettingPrivate()
> +: name(NM_SETTING_OVS_BRIDGE_SETTING_NAME)
> +, mcastSnoopingEnable(false)

Coding style.

> ovsbridgesetting.cpp:154
> +{
> +    dbg.nospace() << "type: " << setting.typeAsString(setting.type()) << '\n';
> +    dbg.nospace() << "initialized: " << !setting.isNull() << '\n';

Why this is commented out?

> ovsbridgesetting.h:35
> +/**
> + * Represents generic setting
> + */

Represents ovs-bridge setting

> ovsinterfacesetting.cpp:25
> +#include <QDebug>
> +
> +NetworkManager::OvsInterfaceSettingPrivate::OvsInterfaceSettingPrivate()

Add define for NM_SETTING_OVS_INTERFACE_SETTING_NAME in case NM is older than 1.10.0.

> ovsinterfacesetting.cpp:27
> +NetworkManager::OvsInterfaceSettingPrivate::OvsInterfaceSettingPrivate()
> +: name(NM_SETTING_OVS_INTERFACE_SETTING_NAME)
> +{ }

Coding style.

> ovsinterfacesetting.cpp:89
> +{
> +    // dbg.nospace() << "type: " << setting.typeAsString(setting.type()) << '\n';
> +    dbg.nospace() << "initialized: " << !setting.isNull() << '\n';

Why this is commented out?

> ovsinterfacesetting.h:35
> +/**
> + * Represents generic setting
> + */

Represents ovs-interface setting

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17239

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181130/dbc54ecf/attachment-0001.html>