D17238: Explicitly create QDateTime with UTC time
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Nov 29 16:17:03 GMT 2018
broulik created this revision.
broulik added reviewers: dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise it spends half of the time doing timezone conversions to local time.
TEST PLAN
- Copied a million files. Time spent in `QDateTime::setMSecsSinceEpoch` went from 44% to 0.1%, total time of `addCopyInfoFromUDSEnty` went from 57% to 36%, now the bottleneck is all that path concatenation causing URL decoding.
- Verified that copied files still have correct mtime
- Verified that "overwrite?" dialog still shows correct mtime
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17238
AFFECTED FILES
src/core/copyjob.cpp
To: broulik, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181129/18f50000/attachment.html>
More information about the Kde-frameworks-devel
mailing list