D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> lbeltrame wrote in basicindexingjob.cpp:153
> Remove instead of committing commented out code?

I prefer not to remove it, at least not completely. I think it is useful to have the mimetypes listed explicitly, so if someone greps for it it is obvious these are already covered.
probably:

  // The pre-XML MS Office formats are already covered by the "contains" above:
  // "application/vnd.ms-powerpoint"
  // "application/vnd.ms-excel"

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17089

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181122/d259953b/attachment.html>