D17051: Use correct variable type for returned value from read/sendfile

David Edmundson noreply at phabricator.kde.org
Tue Nov 20 14:06:44 GMT 2018


davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  n stores the read/transferred bytes. This returns a ssize_t.
  We were casting to an int, which theoretically is a loss of data.
  
  In practice it isn't an issue as we only read a max of MAX_IPC_SIZE at a
  time, which would fit in an int.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17051

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181120/01619c4b/attachment.html>


More information about the Kde-frameworks-devel mailing list