D17013: Show menu bar, how to re-enable, common shortcut dialog

Albert Astals Cid noreply at phabricator.kde.org
Mon Nov 19 18:29:25 GMT 2018


aacid added inline comments.

INLINE COMMENTS

> ktoggleshowmenubaraction.cpp:77
> +        KMessageBox::information(d->window, tr("This will hide the menu bar completely."
> +                                            " You can show it again by typing %1.").arg(d->q->shortcut().toString()),
> +                                tr("Hide menu bar"),

If shortcut() returns a QKeySequence (i think it does), you want toString(NativeText)

Not a native speaker but i don't think "typing" is what you want, i'd say "pressing".

Also what if there's no shortcut?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181119/f6b34a94/attachment.html>


More information about the Kde-frameworks-devel mailing list