D17013: Show menu bar, how to re-enable, common shortcut dialog

Christoph Feck noreply at phabricator.kde.org
Mon Nov 19 14:12:35 GMT 2018


cfeck added inline comments.

INLINE COMMENTS

> ktoggleshowmenubaraction.cpp:21
> +
> +#include "ktoggleshowmenubaraction.h"
> +

Do we still follow the rule "include own headers first"?

> ktoggleshowmenubaraction.h:28
> + * An action to hide or show the menubar of a window.
> + * The action by default remind the user how to show back
> + * the menu bar using the keyboard shortcut.

reminds

Additionally, "show back" does not sound like proper english, but I am not a native english speaker.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham
Cc: cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181119/b7b91acf/attachment.html>


More information about the Kde-frameworks-devel mailing list