D15983: React to config updates inside indexer

[Igor Poboiko]

poboiko updated this revision to Diff 45452.
poboiko added a comment.


  It's a bad idea to removeRecursively starting from root of the tree (documentid 0).
  If user has indexed `/home/username` folder, there is also an index entry for `/home` (that's how IdTreeDB works).
  However, `/home` should not be indexed, according to checks (because it's not in includeFolders, while `/home/username` is)
  This will lead to `removeRecursively("/home")` call, which will wipe index for `/home/username` as well.
  
  Instead I propose to do checks based on `includeFolders` and `excludeFolders` 
  (which could have changed if config was changed and some directory was added to exclude list)

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15983?vs=45451&id=45452

BRANCH
  arcpatch-D15983

REVISION DETAIL
  https://phabricator.kde.org/D15983

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/file/indexcleaner.cpp
  src/file/mainhub.cpp

To: poboiko, #baloo, #frameworks
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181114/c7ea70c0/attachment.html>