D16617: fix extraction of GPS altitude for exif data

Alexander Stippich noreply at phabricator.kde.org
Sat Nov 10 13:56:15 GMT 2018


astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractor.cpp:285
> According to:
> https://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/GPS.html
> and
> http://www.cipa.jp/std/documents/e/DC-008-Translation-2016-E.pdf
> 
> the absolute altitude value is a rational, like deg/min/sec.

true, but why not use the converted value directly? Otherwise the conversion would have to be made manually by dividing, see fetchGpsDouble()

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181110/e5d526bf/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list