D16770: [ftp kio-slave] Fix deletion of directory with non-latin parent path

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Nov 9 00:53:38 GMT 2018


kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  KRemoteEncoding::directory() returns the encoded path of the directpry,
  while Ftp::ftpFolder() takes the un-encoded version.
  The implicit casting from QByteArray via QString::fromUtf8 to the QString
  type for the Ftp::ftpFolder() arg blocked the compiler from complaining about
  that coding mismatch. Possibly also non-latin1 characters being rare with
  ftp server directory layouts prevented this bug being hit so far.

TEST PLAN
  No ftp server availble with deletion rights myself, so only theoretically
  a bug seen and fixed.

REPOSITORY
  R241 KIO

BRANCH
  fixFtpDirdelete

REVISION DETAIL
  https://phabricator.kde.org/D16770

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181109/444e53e4/attachment.html>


More information about the Kde-frameworks-devel mailing list