D16643: Correct the accept flag of the event object on DragMove

trmdi noreply at phabricator.kde.org
Thu Nov 8 01:02:37 GMT 2018


trmdi added a comment.


  In D16643#355177 <https://phabricator.kde.org/D16643#355177>, @bruns wrote:
  
  > You have a conceptual misunderstanding of the enabled property, see QQuickItem <http://doc.qt.io/qt-5/qml-qtquick-item.html#enabled-prop>
  >
  > > enabled : bool
  > >  This property holds whether the item receives mouse and keyboard events. By default this is true.
  >
  >
  
  
  Yes, but what do you think about this:
  http://doc.qt.io/qt-5/qevent.html#accepted-prop
  
  > accepted : bool
  >  Setting the accept parameter indicates that the event receiver wants the event.
  
  Isn't DragArea the event receiver?
  
  > It would also be good if you stick to one issue at a time.
  
  Why for a very simple one-line patch ?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181108/c0684565/attachment.html>


More information about the Kde-frameworks-devel mailing list