D16708: [server] Text input content hint and purpose per protocol version

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> romangg wrote in textinput_interface.cpp:67
> wlPurpose is also an abbreviation. ;)
> 
> And in the header file it is named `purpose`. Makes more sense to me to have the name without abbreviation in the API. I'll rename the function variable though.

> wlPurpose is also an abbreviation. ;)

You caught me. :D

> textinput_interface_p.h:69
>  
> +    virtual TextInputInterface::ContentHints convertContentHint(uint32_t hint) = 0;
> +    virtual TextInputInterface::ContentPurpose convertContentPurpose(uint32_t purpose) = 0;

Can be const.

REPOSITORY
  R127 KWayland

BRANCH
  textInputEnums

REVISION DETAIL
  https://phabricator.kde.org/D16708

To: romangg, #kwin, #frameworks, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181106/ee45d9c2/attachment.html>