D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Current code contains a path to cleanup
  PlasmaVirtualDesktopManagementInterface's list of destops if the
  PlasmaVirtualDesktop object is destroyed.
  
  However at the time that this is run, the entry in the list is already
  dangling and therefore shouldn't be used.
  
  This patch moves the cleanup logic into the destructor of
  PlasmaVirtualDesktop, however this means we need to make sure
  PlasmaVirtualDesktopManagementInterface outlives the
  PlasmaVirtualDesktop by performing an explicit early cleanup instead of
  relying on QObject.

TEST PLAN
  Relevant unit test still passes.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16686

AFFECTED FILES
  src/server/plasmavirtualdesktop_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181105/13622550/attachment.html>