D16665: Add programmaticaly useful error signalling

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Nov 5 00:10:15 GMT 2018


apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> engine.h:430
> +     */
> +    void signalErrorCode(const KNSCore::ErrorCode &errorCode, const QVariant &metadata);
>  

I would include the error message here and deprecate `signalError`. Otherwise it's going to be a mess matching both signals.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181105/b01ae15d/attachment.html>


More information about the Kde-frameworks-devel mailing list