D16591: [XmlExtractor] Use QXmlStreamReader for better performance

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Nov 2 23:44:39 GMT 2018


apol added a comment.


  Patch looks good overall +1

INLINE COMMENTS

> bruns wrote in xmlextractortest.cpp:70
> QDomElement::text() leaves a final trailing whitespace which is not trimmed.

Won't this break any use?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181102/83e4c3b1/attachment.html>


More information about the Kde-frameworks-devel mailing list