D16579: Musepack disk number field name is DISC.

[Alexander Stippich]

astippich added a comment.


  In D16579#352255 <https://phabricator.kde.org/D16579#352255>, @smithjd wrote:
  
  > I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the standard then is a more viable course of action.
  
  
  In an ideal world, yes of course. But it is just not going to happen that every user changes its tags according to the "standard" because KFileMetaData decided to stick to it. Instead, we get complaints or bug reports about it.
  Think about it from an end-user perspective, who doesn't know anything about the specific tags, and just wants to edit the tags of a music file. One opens kid3, clicks the 'Add' button, starts typing 'disc...' and kid3 then proposes 'Disc Number'. The user uses it and wonders why it doesn't show up in Dolphin afterwards and complains.
  
  You can also argue that it's actually not a standard, it's an agreement. Both ape and vorbis tags allow to write arbitrary tags to the file. From that perspective, both are actually valid entries. Since it really is a matter of 3 lines of code, please just add it.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/359e2339/attachment-0001.html>