D16490: [XmlExtractor] Add unittest for XML extractor

Alexander Stippich noreply at phabricator.kde.org
Thu Nov 1 16:14:44 GMT 2018


astippich added a comment.


  I understand that ExtractorCollection is not used, and that the extractor gets the mimetype directly set in the test.
  But the list retrieved via XmlExtractor::mimetypes() is part of the extractor itself, isn't it? So imho that should be tested here.
  All I'm asking for is something similar to https://phabricator.kde.org/source/kfilemetadata/browse/master/autotests/embeddedimagedatatest.cpp$48

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/3fd3fc4d/attachment.html>


More information about the Kde-frameworks-devel mailing list