D16591: [XmlExtractor] Use QXmlStreamReader for better performance
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Thu Nov 1 16:02:52 GMT 2018
bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
At least in the benchmark, QXmlStreamReader is more than twice as fast
as QDomDocument.
TEST PLAN
Before/after:
RESULT : XmlExtractorTests::benchMarkXmlExtractor():
810 msecs per iteration (total: 810, iterations: 1)
RESULT : XmlExtractorTests::benchMarkXmlExtractor():
288 msecs per iteration (total: 288, iterations: 1)
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16591
AFFECTED FILES
autotests/xmlextractortest.cpp
src/extractors/xmlextractor.cpp
To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/154d952f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list