D16554: move supported mimetypes to static string list

Stefan Brüns noreply at phabricator.kde.org
Thu Nov 1 02:09:52 GMT 2018


bruns added inline comments.

INLINE COMMENTS

> epubextractor.cpp:38
> +const QStringList EPubExtractor::mMimetypes =
>  {
> +    QStringLiteral("application/epub+zip"),

Opening braces should go on the same line for everything but functions ...

> epubextractor.cpp:48
>  namespace
>  {
>  QString fetchMetadata(struct epub* e, const epub_metadata& type)

you can put the static mimetypes variable here in the anonymous namespace

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181101/c6048318/attachment.html>


More information about the Kde-frameworks-devel mailing list