D17651: Escape bytes that are larger than or equal to 127 in config files

Jos van den Oever noreply at phabricator.kde.org
Sat Dec 29 16:30:27 GMT 2018


vandenoever added a comment.


  Found it. This is the failing test.
  
    FAIL!  : KConfigTest::testEncoding() Compared values are not the same
       Actual   (lines.first())                    : "[UTF-8:\\xc3\\xb6l]\n"
       Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"
       Loc: [/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 SUSEQt5.11/autotests/kconfigtest.cpp(463)]
  
  The test writes a config file with this group header:
  
  [UTF-8:öl]
  
  The above patch breaks that. Instead it outpus the escaped bytes:
  
  [UTF-8:\xc3\xb6]
  
  I'm working on a fix now.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181229/7687b45b/attachment.html>


More information about the Kde-frameworks-devel mailing list