D17459: SearchBar: Add Cancel button to stop long running tasks

Anthony Fieroni noreply at phabricator.kde.org
Thu Dec 20 19:54:06 GMT 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:89
> +        ret = new KateSearchBarPrivate;
> +        d_func()->insert(foo, ret);
> +    }

You can take another approach

  connect(foo, &Qobject::destroyed, d_func, [foo]() { delete d_func()->take(foo); });

> katesearchbar.cpp:94-97
> +static void delete_d(const KateSearchBar *foo)
> +{
> +    delete d_func()->take(foo);
> +}

Remove.

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181220/07a3f37c/attachment.html>


More information about the Kde-frameworks-devel mailing list