D17542: Reset parentItem when mainItem changes
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Dec 12 14:31:13 GMT 2018
broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise we'll keep piling up custom tooltip items in the dialog. They're invisible but they're still there.
TEST PLAN
Kept the contentItem visible, moved between TM and kickoff, tooltip no longer ends up with multiple items in it:
Before:
F6473103: Screenshot_20181212_151924.png <https://phabricator.kde.org/F6473103>
They're not "leaked" as it doesn't change ownership (`parent` vs `parentItem`) but it still adds unnccessary invisible items to the window
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D17542
AFFECTED FILES
src/plasmaquick/dialog.cpp
To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181212/5fc36646/attachment.html>
More information about the Kde-frameworks-devel
mailing list