D17425: dcb settings

Jan Grulich noreply at phabricator.kde.org
Mon Dec 10 11:41:54 GMT 2018


jgrulich added inline comments.

INLINE COMMENTS

> dcbsetting.h:106
> +    /////////
> +    void setPriorityFlowControlList(UintList list);
> +    UintList priorityFlowControlList() const;

Move them please among the rest of methods, so all related methods are next to each other. Also use please "const UintList &list" and do not name the method as setFooList(), they can be just setFoo().

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181210/b12c2c2b/attachment.html>


More information about the Kde-frameworks-devel mailing list