D17381: macsec setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> macsecsetting.cpp:49
> +    , sendSci(true)
> +    , validation(NetworkManager::MacsecSetting::Disable)
> +{ }

Isn't default validation 2, which means "strict" in your case.

> macsecsetting.cpp:294
> +
> +    if (mode() > 0) {
> +        setting.insert(QLatin1String(NM_SETTING_MACSEC_MODE), (int)mode());

mode() > Macsec::Psk

> macsecsetting.cpp:310
> +
> +    if (validation() >= 0) {
> +        setting.insert(QLatin1String(NM_SETTING_MACSEC_VALIDATION), (int)validation());

validation() != Macsec::Strict

> macsecsetting.h:50
> +
> +    enum Mode{
> +        Psk = NM_SETTING_MACSEC_MODE_PSK,

In this case you don't need to define the defines above, just list both enums without assigned values, or you can just assign 0 to the first one to make sure it starts from 0.

> macsecsetting.h:70
> +
> +    void setMkaCak(QString mkaCak);
> +    QString mkaCak() const;

const QString &mkaCak

> macsecsetting.h:73
> +
> +    void setMkaCkn(QString mkaCkn);
> +    QString mkaCkn() const;

const QString &mkaCkn

> macsecsetting.h:79
> +
> +    void setParent(QString parent);
> +    QString parent() const;

const QString &parent

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181207/347d0f2d/attachment-0001.html>