D17392: Fix checkDesktopFile function

Aleksei Nikiforov noreply at phabricator.kde.org
Thu Dec 6 19:16:09 GMT 2018


i.Dark_Templar created this revision.
i.Dark_Templar added a reviewer: davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
i.Dark_Templar requested review of this revision.

REVISION SUMMARY
  Variable isLocal is no longer initialized anywhere.
  Return function call which set it's value before while still discarding value returned by that function.
  Also provide default value (false) for variable isLocal since function
  items.mostLocalUrl(...) might not set a value to it if item is empty.
  
  Alternatively, remains of isLocal variable and it's usage probably should be removed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17392

AFFECTED FILES
  src/core/kfileitem.cpp

To: i.Dark_Templar, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181206/514879da/attachment.html>


More information about the Kde-frameworks-devel mailing list