D17381: macsec setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> macsecsettingtest.cpp:29
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MACSEC_PARENT               "parent"

This required version is not true, please verify it properly, I'm not going to do it every time :).

> macsecsetting.cpp:26
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MACSEC_SETTING_NAME         "macsec"

Same wrong NM version as in the test.

> macsecsetting.cpp:311
> +
> +    if (mkaCakFlags()) {
> +        setting.insert(QLatin1String(NM_SETTING_MACSEC_MKA_CAK_FLAGS), (int)mkaCakFlags());

Flags should be inserted to the map all the time.

> macsecsetting.h:58
> +
> +    void setMode(qint32 mode);
> +    qint32 mode() const;

Can be turned into an enum.

> macsecsetting.h:70
> +
> +    void setValidation(qint32 validation);
> +    qint32 validation() const;

Can be turned into an enum.

> setting.cpp:34
>  
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MACSEC_SETTING_NAME         "macsec"

Again not true.

REVISION DETAIL
  https://phabricator.kde.org/D17381

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181206/e311537a/attachment.html>