D17357: extend list of supported mimetypes for embedded image extractor

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Dec 4 23:38:24 GMT 2018


bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Can you mention the file types and their corresponding mimetypes in the Summary? Thx.

INLINE COMMENTS

> embeddedimagedata.cpp:199
> +        if (speexFile.tag()) {
> +            return getFrontCoverFromFlacPicture(speexFile.tag()->pictureList());
> +        }

Comment about tag->isEmpty() from D16671 <https://phabricator.kde.org/D16671> applies here as well

REPOSITORY
  R286 KFileMetaData

BRANCH
  image_extend

REVISION DETAIL
  https://phabricator.kde.org/D17357

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181204/dd9ad6eb/attachment.html>


More information about the Kde-frameworks-devel mailing list