D17302: add simple test for string merging

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Dec 2 13:56:54 GMT 2018


bruns added inline comments.

INLINE COMMENTS

> resulttest.cpp:2
> +/*
> + * <one line to give the library's name and an idea of what it does.>
> + * Copyright (C) 2018 Alexander Stippich <a.stippich at gmx.net>

^_^

> resulttest.cpp:39
> +
> +        Result result(QStringLiteral("test"),QStringLiteral("audo/mpeg3"),KFileMetaData::ExtractionResult::ExtractEverything);
> +        result.setDocument(doc);

Spaces and linebreaks ...

> resulttest.cpp:40
> +        Result result(QStringLiteral("test"),QStringLiteral("audo/mpeg3"),KFileMetaData::ExtractionResult::ExtractEverything);
> +        result.setDocument(doc);
> +

No need to reset the default constructed `Baloo::Document` with a default constructed one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181202/56b3a708/attachment.html>


More information about the Kde-frameworks-devel mailing list