Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

Albert Astals Cid aacid at kde.org
Mon Jan 2 11:31:01 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129750/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: solid


Description
-------

in src/solid/power/power.h i changed States to InhibitionTypes since States doesn't exist

https://woboq.com/blog/q_enum.html


Diffs
-----

  src/solid/devices/frontend/battery.h e7a9d6d 
  src/solid/devices/frontend/deviceinterface.h dd212cc 
  src/solid/devices/frontend/genericinterface.h cf043b1 
  src/solid/devices/frontend/networkshare.h 3cfde67 
  src/solid/devices/frontend/opticaldisc.h 9412b73 
  src/solid/devices/frontend/opticaldrive.h 6f70494 
  src/solid/devices/frontend/processor.h 2153b2c 
  src/solid/devices/frontend/storagedrive.h b2f70bc 
  src/solid/devices/frontend/storagevolume.h 59903ad 
  src/solid/power/inhibition.h 4616f39 
  src/solid/power/inhibitionjob.h 0c0c233 
  src/solid/power/job.h 789bc8c 
  src/solid/power/power.h 35f9032 

Diff: https://git.reviewboard.kde.org/r/129750/diff/


Testing
-------


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170102/fa2145ec/attachment.html>


More information about the Kde-frameworks-devel mailing list