D8536: Add more hashing algorithms to KPropertiesDialog

Anthony Fieroni noreply at phabricator.kde.org
Wed Dec 27 18:30:18 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> petermajchrak wrote in kpropertiesdialog.cpp:2798-2804
> But adding a mutex for guarding the body of the mapper function will serialize the hash computations. The computations themselves are independent and parallelizable, only the synchronization points (cachedChecksum and cacheChecksum) are not.

I understand but you don't have a choice, now this *works* on luck you can face a crash when one thread read caches while one writes it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171227/0dfdd557/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list