D9332: Allow filter places based on alternative application name

Albert Astals Cid noreply at phabricator.kde.org
Thu Dec 14 16:39:12 UTC 2017


aacid added inline comments.

INLINE COMMENTS

> kfileplacesmodel.h:67
>  
> -    KFilePlacesModel(QObject *parent = nullptr);
> +    KFilePlacesModel(QObject *parent = nullptr, const QString &alternativeApplicationName = {});
>      ~KFilePlacesModel();

This breaks ABI so it's not acceptable.

Also how does this fix anything if the new alternativeApplicationName parameter is never passed in any of the existing constructors?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9332

To: renatoo, mwolff
Cc: aacid, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171214/a58f4ddf/attachment.html>


More information about the Kde-frameworks-devel mailing list