D9206: Implement a kfile dialog where we can add custom widget

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:41
>  
> +
>  )

nothing to see here

> kfilecustomdialog.cpp:65
> +
> +void KFileCustomDialogPrivate::setUrl(const QUrl &url)
> +{

I wonder about the usefulness of these indirection methods, the only caller could do d->mFileWidget->setUrl(url), but well. Your choice :)

(same for the 3 that follow, I don't see much benefit, but OK I don't see much harm either)

> kfilecustomdialog.h:61
> +     * @brief fileWidget
> +     * @return the filewidget element
> +     */

"element" seems weird here. Maybe something like this?

@return the filewidget used inside this dialog

REPOSITORY
  R241 KIO

BRANCH
  add_kfile_dialog

REVISION DETAIL
  https://phabricator.kde.org/D9206

To: mlaurent, mwolff, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171214/64006530/attachment.html>