D9136: Add support for version 3 of data device manager interface

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Dec 10 16:56:42 UTC 2017


broulik added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  lgtm

INLINE COMMENTS

> datadevice.cpp:177
>  {
> +    if (d->drag.offer) {
> +        delete d->drag.offer;

`delete nullptr` is just fine

> datadevicemanager.h:74
> +        Move = 1 << 1,
> +        Ask = 1 << 2
> +    };

Should `Ask` perhaps become a bigger number in  case stuff gets added in the middle later like `Link` or is that unlikely/incompatible?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D9136

To: graesslin, #frameworks, #plasma, #kwin
Cc: broulik, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171210/28cdf094/attachment.html>


More information about the Kde-frameworks-devel mailing list