D9241: Emit 'groupHiddenChanged' signal.

Milian Wolff noreply at phabricator.kde.org
Thu Dec 7 14:57:51 UTC 2017


mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:1215
> +    QList<QVariant> args = groupHiddenSignal.takeFirst();
> +    QCOMPARE(args.at(0).toInt(), (int) KFilePlacesModel::SearchForType);
> +    QCOMPARE(args.at(1).toBool(), true);

`static_cast<int>()` would be preferred, also below

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9241

To: renatoo, franckarrecot, mwolff
Cc: mwolff, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171207/b18aa654/attachment.html>


More information about the Kde-frameworks-devel mailing list