D9120: Fix a memory leak

[Jaime Torres Amate]

jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  setup was created but never released, now changed to a member pointer
  to be deleted in the destructor.
  According to valgrind, the leak is gone.

TEST PLAN
  this leak is gone
  
  25519== 58,922 (80 direct, 58,842 indirect) bytes in 1 blocks are definitely lost in loss record 2,937 of 2,937
  ---------------------------------------------------------------------------------------------------------------
  
  25519==    at 0x4C2E08F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  ------------------------------------------------------------------------------------------
  
  25519==    by 0xAC57C3C: QHashData::allocateNode(int) (in /usr/lib64/libQt5Core.so.5.9.2)
  -----------------------------------------------------------------------------------------
  
  25519==    by 0x82F3089: QHash<QString, KuitTag>::createNode(unsigned int, QString const&, KuitTag const&, QHashNode<QString, KuitTag>**) (qhash.h:551)
  -------------------------------------------------------------------------------------------------------------------------------------------------------
  
  25519==    by 0x82EF67F: QHash<QString, KuitTag>::operator[](QString const&) (qhash.h:751)
  ------------------------------------------------------------------------------------------
  
  25519==    by 0x82E10EA: KuitSetupPrivate::setTagPattern(QString const&, QStringList const&, Kuit::VisualFormat, KLocalizedString const&, QString (*)(QStringList const&, QString const&, QHash<QString, QString> const&, QString const&, QStringList const&, Kuit::VisualFormat), int) (kuitmarkup.cpp:546)
  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  
  25519==    by 0x82E7FA6: KuitSetupPrivate::setDefaultMarkup() (kuitmarkup.cpp:994)
  ----------------------------------------------------------------------------------
  
  25519==    by 0x82E97E6: KuitSetup::KuitSetup(QByteArray const&) (kuitmarkup.cpp:1089)
  --------------------------------------------------------------------------------------
  
  25519==    by 0x82E101C: Kuit::setupForDomain(QByteArray const&) (kuitmarkup.cpp:504)
  -------------------------------------------------------------------------------------
  
  25519==    by 0x82E9979: KuitFormatterPrivate::format(QByteArray const&, QString const&, QString const&, Kuit::VisualFormat) const (kuitmarkup.cpp:1212)
  --------------------------------------------------------------------------------------------------------------------------------------------------------
  
  25519==    by 0x82ED234: KuitFormatter::format(QByteArray const&, QString const&, QString const&, Kuit::VisualFormat) const (kuitmarkup.cpp:1692)
  -------------------------------------------------------------------------------------------------------------------------------------------------
  
  25519==    by 0x82C8F0B: KLocalizedStringPrivate::formatMarkup(QByteArray const&, QString const&, QString const&, QString const&, Kuit::VisualFormat) const (klocalizedstring.cpp:800)
  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  
  25519==    by 0x82C7EC2: KLocalizedStringPrivate::toString(QByteArray const&, QStringList const&, Kuit::VisualFormat, bool) const (klocalizedstring.cpp:610)
  ------------------------------------------------------------------------------------------------------------------------------------------------------------

REPOSITORY
  R249 KI18n

BRANCH
  memleak (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9120

AFFECTED FILES
  src/kuitmarkup.cpp

To: jtamate, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171203/52ce751d/attachment-0001.html>