D7929: [WIP] Add new Column View option to KDirOperator

David Faure noreply at phabricator.kde.org
Sat Dec 2 19:13:32 UTC 2017


dfaure added a comment.


  In https://phabricator.kde.org/D7929#174598, @fvogt wrote:
  
  > - I really dislike the Qt contribution process :-/
  
  
  As opposed to KDE where it took more than 2 months to get a reply? ;)
  
  > - Nobody seems to maintain this upstream (I expect this to be gone in Qt 6)
  
  Well, there's a new QtWidgets maintainer I hear, and you could become maintainer of QColumnView, problem solved :-)
  
  > and this is probably the only user of QColumnView anyway
  
  So https://bugreports.qt.io/issues/?jql=text%20~%20%22QColumnView%22 appeared out of thin air? :-)
  
  > - This introduces breaking changes (both API and behavioural), not sure how to align those...
  
  Can't comment without seeing the changes as a diff. API can often be worked around with a bit of redundancy (old method + new method) but behaviour is more difficult indeed.
  
  > Additionally there are some bugs I found that need to be fixed meanwhile:
  > 
  > - If the path contains a component that is not included in the KDirModel (hidden, for example), it breaks
  > - Sometimes it's required to click twice on a folder to open it
  
  That's just bugs, can be fixed :)
  
  > Also, there's still the point that dolphin doesn't implement this and likely never will (if dolphin were using proper QAbstractItemModel it would just work (tm)...).
  
  It used to... then they wanted more (e.g. animation when deleting a file)...
  (I guess there are more reasons)
  
  > I'm not quite sure what to do here, but it seems to require a lot of work outside of the actual implementation which I'm not going to to, I'm afraid.
  
  Your call. I'm not fond enough of column-views myself to offer any substantial help.
  But I'm not very happy about a fork of a Qt class ending up in a framework I maintain, in the long run.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7929

To: fvogt, #frameworks
Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171202/1d013acb/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list